feat: Added adopt-root-styles property for templated content#46
Open
rkaraivanov wants to merge 1 commit intomasterfrom
Open
feat: Added adopt-root-styles property for templated content#46rkaraivanov wants to merge 1 commit intomasterfrom
rkaraivanov wants to merge 1 commit intomasterfrom
Conversation
Add support for adopting document-level styles into shadow DOM when using cell and header templates. This enables custom styles defined in the light DOM to be applied to templated content within web components. Changes: - Added AdoptedStylesController to manage style adoption in shadow DOM - Added `adopt-root-styles` property to grid component - Implemented style adoption in cell and header components when templates are used - Added unit tests for AdoptedStylesController and style adoption functionality - Optimizeed rendering by replacing `map` directive with `repeat` directive The controller caches adopted stylesheets per document and handles theme changes by invalidating the cache. Styles are only adopted when the property is enabled AND a template is provided, ensuring minimal overhead when not in use.
Pull Request Test Coverage Report for Build 21853839417Details
💛 - Coveralls |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for adopting document-level styles into shadow DOM when using cell and header templates. This enables custom styles defined in the light DOM to be applied to templated content within web components.
Changes:
adopt-root-stylesproperty to grid componentmapdirective withrepeatdirectiveThe controller caches adopted stylesheets per document and handles theme changes by invalidating the cache. Styles are only adopted when the property is enabled AND a template is provided, ensuring minimal overhead when not in use.